Simplify and clarify the conflict of interest text#4780
Merged
Conversation
This had gotten too convoluted and in any case should permit people to add collection changes for their own projects.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the conflict-of-interest check by replacing a lengthy requirement with a concise “self-promotion” confirmation.
- Streamline workflow echo messages and condition checks to use “This change is not self-promotion.”
- Update the PR template bullet to match the new phrasing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/conflict.yml | Updated echo statements and if clauses for self-promotion check |
| .github/PULL_REQUEST_TEMPLATE.md | Replaced detailed author check with a self-promotion checkbox |
Comments suppressed due to low confidence (2)
.github/workflows/conflict.yml:17
- The echo statement is missing a closing quotation mark, which will cause a syntax error and break the workflow.
echo "> This change is not self-promotion.
.github/PULL_REQUEST_TEMPLATE.md:5
- The markdown list item appears as
- [ ]but the diff shows-- [ ], which may render incorrectly; ensure it uses a single dash for a proper checklist item.
- [ ] This change is not self-promotion.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had gotten too convoluted and in any case should permit
people to add collection changes for their own projects.
Please confirm this pull request meets the following requirements:
Which change are you proposing?